String Validator improvement to support OpenAPI & AsyncAPI specs #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Mar 25, 2024
Comment on lines
46
to
47
| id: string | ||
| id: | ||
| model: string |
There was a problem hiding this comment.
Do we still support the abbreviated syntax for convenience?
There was a problem hiding this comment.
no, this is not supported anymore. Should we continue supporting this syntax?
There was a problem hiding this comment.
As discussed, we will be supporting abbreviated syntax for convenience.
jfallows
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
string validation
- max and min length
- regular expressions