Support ability to connect to specific kafka cluster node hostname #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
previously approved these changes
Dec 12, 2023
jfallows
previously approved these changes
Dec 12, 2023
jfallows
approved these changes
Dec 12, 2023
jfallows
requested changes
Dec 12, 2023
| @@ -1280,6 +1280,7 @@ private void doConnectionBegin( | |||
| .destination(host) | |||
| .sourcePort(0) | |||
| .destinationPort(port))) | |||
| .infos(i -> i.item(ii -> ii.authority(host))) | |||
There was a problem hiding this comment.
This should be coming from ProxyBeginEx info authority, not host, and address key for shared connections should include authority in addition to host and port, agree?
Otherwise, two streams differing only by authority would be treated as equal, even though their TLS handshakes would have a different sni.
jfallows
approved these changes
Dec 12, 2023
| @@ -79,7 +78,7 @@ public final class KafkaClientConnectionPool extends KafkaClientSaslHandshaker | |||
| private static final int SIGNAL_STREAM_WINDOW = 0x80000006; | |||
| private static final int SIGNAL_CONNECTION_CLEANUP = 0x80000007; | |||
| private static final int SIGNAL_NEXT_REQUEST = 0x80000008; | |||
| private static final String CLUSTER = ""; | |||
| private static final StringBuilder CLUSTER = new StringBuilder(""); | |||
There was a problem hiding this comment.
This needs to be non-static as it is mutable and static is shared across cores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support ability to connect to specific kafka cluster node hostname