Include validators in the mqtt config generator #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attilakreiner
changed the title
attilakreiner
force-pushed
the
gen-mqtt-conf-val
branch
from
9defe28 to
4cbfe96
Compare
jfallows
requested changes
Sep 24, 2023
| import jakarta.json.bind.annotation.JsonbProperty; | ||
|
|
||
| public class Channel | ||
| { | ||
| public String address; | ||
| public LinkedHashMap<String, Message> messages; |
There was a problem hiding this comment.
This should just be Map<String, Message> right?
There was a problem hiding this comment.
It's necessary to maintain the order here for a deterministic output.
- That's needed for the consistent run of the unit tests.
- I believe it's a good practice for the production code, too.
jfallows
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include validators in the
mqttconfig generator.Fixes #461