Extract avro validator #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attilakreiner
force-pushed
the
validator-avro
branch
from
6121137 to
944f48a
Compare
attilakreiner
force-pushed
the
validator-avro
branch
from
944f48a to
a56479b
Compare
attilakreiner
force-pushed
the
validator-avro
branch
from
53f725c to
41d4db2
Compare
jfallows
requested changes
Sep 22, 2023
...afka/src/test/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/CacheFetchIT.java
Outdated
Show resolved
Hide resolved
...afka/src/test/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/CacheFetchIT.java
Outdated
Show resolved
Hide resolved
...inding-kafka.spec/src/test/java/io/aklivity/zilla/specs/binding/kafka/config/SchemaTest.java
Outdated
Show resolved
Hide resolved
jfallows
approved these changes
Sep 22, 2023
| @@ -180,6 +184,8 @@ public final class Engine implements Collector, AutoCloseable | |||
| schemaTypes.addAll(metricGroups.stream().map(MetricGroup::type).filter(Objects::nonNull).collect(toList())); | |||
| schemaTypes.addAll(vaults.stream().map(Vault::type).filter(Objects::nonNull).collect(toList())); | |||
| schemaTypes.addAll(catalogs.stream().map(Catalog::type).filter(Objects::nonNull).collect(toList())); | |||
| schemaTypes.addAll(validatorFactory.validatorSpis().stream().map(ValidatorFactorySpi::schema) | |||
| .filter(Objects::nonNull).collect(toList())); | |||
There was a problem hiding this comment.
Looks good, let's make sure to remove the filter when we have core extracted so every validator factory comes with a schema patch.
| { | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
Also to be removed when core validators are extracted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract the avro validator from
runtime/enginetoincubator/validator-avro.Fixes # (issue)