Merged consumer group support #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Sep 4, 2023
| @@ -57,6 +58,8 @@ read "Hello, world #A5" | |||
| write advise zilla:flush ${kafka:flushEx() | |||
| .typeId(zilla:id("kafka")) | |||
| .merged() | |||
| .typeId(1) | |||
| @@ -43,6 +43,8 @@ connected | |||
| write advise zilla:flush ${kafka:flushEx() | |||
| .typeId(zilla:id("kafka")) | |||
| .merged() | |||
| .typeId(1) | |||
| @@ -2493,49 +3396,65 @@ private void doEncodeSyncGroupRequest( | |||
| final int encodeOffset = DataFW.FIELD_OFFSET_PAYLOAD; | |||
| final int encodeLimit = encodeBuffer.capacity(); | |||
|
|
|||
| int encodeProgress = encodeOffset; | |||
| AtomicInteger encodeProgress = new AtomicInteger(encodeOffset); | |||
There was a problem hiding this comment.
Please use MutableInteger instead if necessary.
| public int routedTypeId() | ||
| { | ||
| return BindingHandler.super.routedTypeId(); | ||
| } |
jfallows
previously approved these changes
Sep 4, 2023
jfallows
approved these changes
Sep 4, 2023
jfallows
approved these changes
Sep 4, 2023
jfallows
pushed a commit
that referenced
this pull request
Sep 5, 2023
* Merged consumer group support (#390) * Adapt to consumer group changes * Change write notify to read * Send init empty data to trigger syncgroup * Add new test --------- Co-authored-by: Akram Yakubov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)