Support for tcp binding to route by port numbers #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to handle port values in JSON, and add tests for reading and writing with port values and port ranges
…cal address in the resolution process.
jfallows
requested changes
Jul 21, 2023
| @@ -281,6 +281,7 @@ public NamespaceConfig parse( | |||
| catch (Throwable ex) | |||
| { | |||
| logError(ex.getMessage()); | |||
| ex.printStackTrace(); | |||
There was a problem hiding this comment.
Please remove this logging.
| InetSocketAddress remote) | ||
| { | ||
| return routes.stream() | ||
| .filter(r -> r.matches(remote.getAddress())) | ||
| .filter(r -> r.matches(local)) |
There was a problem hiding this comment.
Looks like we only need one address parameter here, not both local and remote.
Then in TcpServerFactory, we'd need to pass local socket address to match the local port we are listening on, and in TcpClientFactory, we'd need to pass remote socket address to match the remote port we are connecting to, agree?
jfallows
requested changes
Jul 25, 2023
| @@ -84,7 +84,7 @@ public class TcpServerFactory implements TcpStreamFactory | |||
|
|
|||
| private final ProxyBeginExFW.Builder beginExRW = new ProxyBeginExFW.Builder(); | |||
|
|
|||
| private final EngineContext context; | |||
|
|
|||
There was a problem hiding this comment.
Please remove the extra blank line.
| @@ -280,7 +280,7 @@ public NamespaceConfig parse( | |||
| } | |||
| catch (Throwable ex) | |||
| { | |||
| logError(ex.getMessage()); | |||
|
|
|||
There was a problem hiding this comment.
Apologies, please restore this line.
jfallows
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for tcp binding to route by port numbers
Fixes #294