KafkaMerged acknowledge flush frame #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
May 30, 2023
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaMergedFactory.java
Show resolved
Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaMergedFactory.java
Show resolved
Hide resolved
...pecs/binding/kafka/streams/application/merged/merged.produce.flush.dynamic.hashed/client.rpt
Outdated
Show resolved
Hide resolved
...zilla/specs/binding/kafka/streams/application/merged/merged.produce.flush.dynamic/client.rpt
Outdated
Show resolved
Hide resolved
...zilla/specs/binding/kafka/streams/application/merged/merged.produce.flush.dynamic/server.rpt
Show resolved
Hide resolved
jfallows
approved these changes
Jun 20, 2023
jfallows
requested changes
Jun 20, 2023
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaMergedFactory.java
Show resolved
Hide resolved
jfallows
requested changes
Jun 23, 2023
|
|
||
| return new KafkaProduceFlushExBuilder(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please make sure we have coverage in KafkaFunctionsTest for these new methods.
There was a problem hiding this comment.
I've already added these:
shouldMatchProduceFlushExtension, shouldMatchProduceFlushExtensionWithLatestOffset, shouldGenerateProduceFlushExtension, shouldGenerateProduceFlushExtensionWithLatestOffset
jfallows
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.