Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mqtt-kafka binding implementation #235

Merged
merged 6 commits into from
May 11, 2023
Merged

Mqtt-kafka binding implementation #235

merged 6 commits into from
May 11, 2023

Conversation

bmaidics
Copy link
Contributor

@bmaidics bmaidics commented May 9, 2023

No description provided.

jfallows
jfallows requested changes May 9, 2023
View reviewed changes
jfallows
jfallows requested changes May 11, 2023
View reviewed changes
...java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/config/MqttKafkaHeaderHelper.java Outdated
public final OctetsFW kafkaContentTypeHeaderOctets;
public final OctetsFW kafkaFormatHeaderOctets;
public final OctetsFW kafkaReplyToHeaderOctets;
public final OctetsFW kafkaCorrelationHeaderOctets;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be private?

Suggest renaming kafkaTopicHeaderOctets to kafkaTopicHeaderName, etc.
In general, try to name variables for their intent rather than their type as it helps to better self-document the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We precompute these header name octets in the helper, and use them in PublishProxyFactory. So it's either public or private and we create getters.

jfallows
jfallows reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@jfallows jfallows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see additional feedback.

@jfallows jfallows merged commit d71bf1b into aklivity:feature/mqtt-kafka May 11, 2023
@jfallows jfallows linked an issue May 11, 2023 that may be closed by this pull request
MQTT and MQTT-Kafka bindings #196
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MQTT and MQTT-Kafka bindings
2 participants
@bmaidics @jfallows