Generic helm chart #230
Merged
Generic helm chart #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attilakreiner
force-pushed
the
helm
branch
6 times, most recently
from
36ab993 to
4df48f8
Compare
jfallows
requested changes
May 12, 2023
cloud/helm-chart/pom.xml
Outdated
| </licenses> | ||
|
|
||
| <build> | ||
| <plugins> |
There was a problem hiding this comment.
Please add the license check goal.
There was a problem hiding this comment.
updated, pls chk
cloud/helm-chart/Chart.yaml
Outdated
| description: Zilla The Event-Driven API Gateway | ||
| type: application | ||
| version: 0.1.0 | ||
| appVersion: "0.9.42" |
There was a problem hiding this comment.
This is hard coded, but should come from build version so it is always up-to-date as part of the release.
There was a problem hiding this comment.
updated, pls chk
jfallows
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change implements a general purpose helm chart for zilla, such that it can be reused by our zilla-examples, but without any special knowledge of how the zilla-examples work.
Fixes #242