Enhance config #228
Merged
Enhance config #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
May 4, 2023
.../main/scripts/io/aklivity/zilla/specs/binding/grpc/kafka/schema/grpc.kafka.schema.patch.json
Outdated
Show resolved
Hide resolved
.../main/scripts/io/aklivity/zilla/specs/binding/grpc/kafka/schema/grpc.kafka.schema.patch.json
Outdated
Show resolved
Hide resolved
.../main/scripts/io/aklivity/zilla/specs/binding/grpc/kafka/schema/grpc.kafka.schema.patch.json
Outdated
Show resolved
Hide resolved
...aklivity/zilla/runtime/binding/grpc/kafka/internal/config/GrpcKafkaOptionsConfigAdapter.java
Outdated
Show resolved
Hide resolved
...io/aklivity/zilla/runtime/binding/grpc/kafka/internal/config/GrpcKafkaWithProduceResult.java
Outdated
Show resolved
Hide resolved
...a/io/aklivity/zilla/runtime/binding/kafka/grpc/internal/config/KafkaGrpcConditionConfig.java
Show resolved
Hide resolved
...livity/zilla/runtime/binding/kafka/grpc/internal/config/KafkaGrpcConditionConfigAdapter.java
Outdated
Show resolved
Hide resolved
...aklivity/zilla/runtime/binding/kafka/grpc/internal/config/KafkaGrpcOptionsConfigAdapter.java
Outdated
Show resolved
Hide resolved
.../aklivity/zilla/runtime/binding/kafka/grpc/internal/stream/KafkaGrpcRemoteServerFactory.java
Outdated
Show resolved
Hide resolved
...ty/zilla/runtime/binding/kafka/grpc/internal/config/KafkaGrpcConditionConfigAdapterTest.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
May 5, 2023
| @@ -63,7 +63,7 @@ public JsonObject adaptToJson( | |||
| if (condition.service != null) | |||
| { | |||
| String method = condition.service; | |||
| method = condition.method != null ? method + "/" + condition.method : method; | |||
| method = condition.method != null ? String.format("%s/%s", method, condition.method) : method; | |||
There was a problem hiding this comment.
Shouldn't we have /* on the end when the method is null instead of just the service by itself?
There was a problem hiding this comment.
if the user has specified method: test then it doesn't expect /* I think no?
There was a problem hiding this comment.
In the schema, we only have method now, but we're parsing the value into service and method, where the service part is required.
However, having the syntax method: test to mean the service is test and the method is * is too confusing, agree?
Recommend we change the pattern to require <Service>/<Method> where <Method> can be *, so that method: test/* means service test and any method.
Comment on lines
65
to
66
| String method = condition.service; | ||
| method = condition.method != null ? method + "/" + condition.method : method; | ||
| method = condition.method != null ? String.format("%s/%s", method, condition.method) : method; |
There was a problem hiding this comment.
Suggested change
| String method = condition.service; | |
| method = condition.method != null ? method + "/" + condition.method : method; | |
| method = condition.method != null ? String.format("%s/%s", method, condition.method) : method; | |
| String method = String.format("%s/%s", condition.service, condition.method != null ? condition.method : "*"); |
| @@ -164,9 +164,6 @@ public GrpcKafkaWithProduceResult resolveProduce( | |||
|
|
|||
| GrpcKafkaWithProduceHash hash = new GrpcKafkaWithProduceHash(octetsRW, dashOctetsRW, correlationId, hashBytesRW); | |||
| hash.digestHash(); | |||
There was a problem hiding this comment.
Why do we need to call digestHash() here?
jfallows
previously approved these changes
May 7, 2023
jfallows
previously approved these changes
May 8, 2023
jfallows
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve config
Fixes #226