BugFix: process configURL if the protocol is http #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfusainey Jallow <[email protected]>
jfallows
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpsis repeated twice in the if condition. This means that if the protocol in the URL to the Zilla JSON config file ishttp, then thejava.net.http.HttpClientclient is not used to retrieve the JSON configuration. Instead, aURLConnectionis used.@jfallows I think this will still work with a
configURL.openConnection(). If this was the intended behavior, then i think the other approach will be to simply the if conditionSigned-off-by: Alfusainey Jallow [email protected]