Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command history inplace updates #323

Merged
merged 10 commits into from
Jul 15, 2023
Merged

Conversation

shefalijoshi
Copy link
Collaborator

@shefalijoshi shefalijoshi commented May 25, 2023

Closes #315

Describe your changes:

Rather than create a new view provider and view for command history in openmct-yamcs, added a configuration that indicates that datum for a given object should be updated in place.
Added a unique id for datum that should be aggregated called messageId. This will be used by open mct to update data in place for that message/record.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@jvigliotta jvigliotta requested a review from akhenry June 12, 2023 20:39
Copy link
Collaborator

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stumbled upon a mistaken version update

@unlikelyzero unlikelyzero added this to the Target:2.2.6 milestone Jun 21, 2023
@shefalijoshi shefalijoshi requested a review from ozyx June 22, 2023 03:23
Copy link
Owner

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Some small changes suggested on nasa/openmct#6694 (comment) which has implications for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate multiple command history state changes into a single command history row.
4 participants