Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): adjust static primary outline button border colors #3600

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

rise-erpelding
Copy link
Collaborator

@rise-erpelding rise-erpelding commented Mar 4, 2025

Description

Adjusts static black outline button border color (primary/non-secondary variant) to transparent-black-800 and static white outline button border color (primary/non-secondary variant) to transparent-white-800 for S2 theme. This aligns the border color with the S2 spec.

SWC-496

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  1. Check out the branch locally or use the preview to open the storybook testing preview page for button
  2. Check S2's static white variant to confirm that non-secondary outline button's border color matches the design spec
    • Confirm that border color is transparent-white-800 (opacity is 0.84, previous opacity was 0.44)
  3. Check S2's static white variant to confirm that non-secondary outline button's border color matches the design spec
    • Confirm that border color is transparent-black-800 (opacity is 0.85, previous opacity was 0.94)
  4. Check other test cases within S2 theme
    • Confirm that there are no unexpected regressions to other variants
  5. Check S1/Express themes
    • Confirm there are no unexpected regressions to other themes

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

S2 Static white before:
image
S2 Static white after (decreased opacity):
image

S2Static black before:
image
S2 Static black after (increased opacity):
image

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 29b2d09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 4, 2025

File metrics

Summary

Total size: 2.25 MB*

Package Size Minified Gzipped
button 38.55 KB 36.64 KB 4.21 KB

button

Filename Head Minified Gzipped Compared to base
index-base.css 31.05 KB 29.48 KB 3.80 KB -
index-theme.css 12.40 KB 12.01 KB 1.14 KB -
index.css 38.55 KB 36.64 KB 4.21 KB -
metadata.json 19.96 KB - - 🔴 ⬆ 0.08 KB
themes/express.css 9.68 KB 9.38 KB 1.06 KB -
themes/spectrum-two.css 9.44 KB 9.15 KB 1.07 KB -
themes/spectrum.css 9.76 KB 9.46 KB 1.08 KB -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

🚀 Deployed on https://pr-3600--spectrum-css.netlify.app

@rise-erpelding rise-erpelding added ready-for-review S2 Spectrum 2 fast-follows An issue or PR that quickly follows a release labels Mar 4, 2025
@rise-erpelding rise-erpelding self-assigned this Mar 4, 2025
@castastrophe castastrophe added the run_vrt For use on PRs looking to kick off VRT label Mar 5, 2025
@rise-erpelding rise-erpelding merged commit bb845cb into main Mar 5, 2025
44 checks passed
@rise-erpelding rise-erpelding deleted the rise-erpelding/swc-496-button-ff branch March 5, 2025 16:45
@github-actions github-actions bot mentioned this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-follows An issue or PR that quickly follows a release ready-for-review run_vrt For use on PRs looking to kick off VRT S2 Spectrum 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants