Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read env file #683

Merged
merged 2 commits into from
Aug 30, 2020
Merged

read env file #683

merged 2 commits into from
Aug 30, 2020

Conversation

ericsciple
Copy link
Collaborator

No description provided.

@ericsciple ericsciple marked this pull request as ready for review August 28, 2020 19:27
@@ -39,5 +39,17 @@ public sealed class GitHubContext : DictionaryContextData, IEnvironmentContextDa
}
}
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thboop i'll rebase after your PR is in

var equalsIndex = line.IndexOf("=", StringComparison.Ordinal);
var heredocIndex = line.IndexOf("<<", StringComparison.Ordinal);

// Normal style NAME=VALUE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great comments !

Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending we fix the tests

@ericsciple ericsciple force-pushed the users/ericsciple/m273output branch from f2a442e to 4b589a7 Compare August 28, 2020 20:25
@ericsciple ericsciple merged commit 3a76a2e into main Aug 30, 2020
@ericsciple ericsciple deleted the users/ericsciple/m273output branch August 30, 2020 03:18
fabianishere pushed a commit to fabianishere/runner that referenced this pull request Sep 23, 2020
Copy link

@tomasreyes tomasreyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H

Copy link

@tomasreyes tomasreyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H

AdamOlech pushed a commit to antmicro/runner that referenced this pull request Jan 28, 2021
TingluoHuang pushed a commit that referenced this pull request Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants