Better Kusto Tracing for self-hosted runner. #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
commented
Apr 7, 2020
| if (credData != null && | ||
| credData.Data.TryGetValue("clientId", out var clientId)) | ||
| { | ||
| _userAgents.Add(new ProductInfoHeaderValue($"RunnerId", clientId)); |
There was a problem hiding this comment.
Only self-hosted runner has the oauth app clientid
TingluoHuang
commented
Apr 7, 2020
| var additionalHeaders = new Dictionary<string, string>(); | ||
| if (!string.IsNullOrEmpty(orchestrationId)) | ||
| { | ||
| additionalHeaders["X-VSS-OrchestrationId"] = orchestrationId; |
There was a problem hiding this comment.
this Header will make everything on the service for this request has the same orchestrationid (activitylog/producttrace)
TingluoHuang
commented
Apr 7, 2020
| { | ||
| var jwt = JsonWebToken.Create(accessToken); | ||
| var claims = jwt.ExtractClaims(); | ||
| orchestrationId = claims.FirstOrDefault(x => string.Equals(x.Type, "orchid", StringComparison.OrdinalIgnoreCase))?.Value; |
There was a problem hiding this comment.
orchestrationid is part of the token's claims
ericsciple
approved these changes
Apr 9, 2020
TingluoHuang
force-pushed
the
users/tihuang/kustoimprove
branch
from
d70fa9c to
7fb3b57
Compare
TingluoHuang
force-pushed
the
users/tihuang/kustoimprove
branch
from
7fb3b57 to
7d85f77
Compare
TingluoHuang
added a commit
that referenced
this pull request
Apr 15, 2020
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding following telemetry for self-hosted runner