Update Runner Register GitHub API URL to Support Org-level Runner #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var gitHubUrl = new UriBuilder(githubUrl); | ||
| var githubApiUrl = $"https://api.{gitHubUrl.Host}/repos/{gitHubUrl.Path.Trim('/')}/actions-runners/registration"; | ||
| var gitHubUrlBuilder = new UriBuilder(githubUrl); | ||
| var githubApiUrl = $"https://api.{gitHubUrlBuilder.Host}/actions/register-runner"; |
There was a problem hiding this comment.
is this new api ready for production usage?
if not, then you probably want to keep the GetTenantCredential() as it is and add a new method, like: GetTenantCredentialPreview(), and flip between these 2 bases on some env variable (GITHUB_NEW_REGISTERENDPOINT=true) to test the new endpoint.
There was a problem hiding this comment.
It'll be in production tomorrow. I just created this little early, so that you can have a look. Will merge it once the api is in production.
TingluoHuang
approved these changes
Feb 20, 2020
TingluoHuang
changed the title
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
…tions#339) * Update GitHub API URL * pr comments * Updated GitHub API URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR
Updated GitHub API request as per this -> https://github.com/github/c2c-actions-runtime/issues/373#issuecomment-588394924
Sample request