-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit on deprication error #2299
Merged
fhammerl
merged 9 commits into
actions:main
from
nikola-jokic:nikola-jokic/deprication-error
Mar 7, 2023
Merged
Exit on deprication error #2299
fhammerl
merged 9 commits into
actions:main
from
nikola-jokic:nikola-jokic/deprication-error
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerl
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nikola-jokic
added a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
* terminate the runner on deprication message * added TaskAgentVersion exception to catch deprication * AccessDenied exception with inner exception InvalidTaskAgent * Access denied exception in program and in message listener * Fixed copy * remove trace message from message listener
Asokol161
reviewed
Jul 25, 2024
@@ -182,7 +182,7 @@ public void OnJobStatus(object sender, JobStatusEventArgs e) | |||
try | |||
{ | |||
_getMessagesTokenSource?.Cancel(); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
';.;;''
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Aug 14, 2024
* terminate the runner on deprication message * added TaskAgentVersion exception to catch deprication * AccessDenied exception with inner exception InvalidTaskAgent * Access denied exception in program and in message listener * Fixed copy * remove trace message from message listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2246