Runner fails to run as a service on windows: Disable Delay Signing on the Runner Service

[thboop]

Running as a service is failing on self hosted windows machines without strong named signing disabled (common customer scenario). This effectively makes running as a service not viable.

Fixes #186
Currently in production RunnerService is getting generated as delay-signed. It should just be unsigned.

PS:  sn -vf RunnerService.exe

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

RunnerService.exe is a delay-signed or test-signed assembly

I did a test release and verified the new version is not signed from this build

PS C:\Users\thboop\downloads\actions-runner-win-x64-1.999.9\bin> sn -vf RunnerService.exe

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

RunnerService.exe does not represent a strongly named assembly
PS C:\Users\thboop\downloads\actions-runner-win-x64-1.999.9\bin>

I was able to verify on a VM with Windows Server 2019 that the issue no longer occurs. I want to do some additional sanity testing.

[TingluoHuang]

Delete the public key under windows service folder that checked in, that’s a MSFT public key

[TingluoHuang]

What’s the default of those csproj setting? Should we just remove them if the default is false?

[bryanmacfarlane]

As part of the testing, let’s test running as svc on macOS and Ubuntu. I realize this change doesn’t affect those but this does identify a testing gap

[thboop]

What’s the default of those csproj setting? Should we just remove them if the default is false?

I prefer these values being explicitly set, but I can understand not wanting to have lines of code that aren't needed. We can take a look at modifying this post GA if needed

Delete the public key under windows service folder that checked in, that’s a MSFT public key

This has been deleted, and the references have been removed.

[thboop]

As part of the testing, let’s test running as svc on macOS and Ubuntu. I realize this change doesn’t affect those but this does identify a testing gap

This works as expected!