Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue data column/col mismatch. #122

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

TingluoHuang
Copy link
Member

No description provided.

@TingluoHuang
Copy link
Member Author

@joshmgross

@@ -239,7 +239,7 @@ private DTWebApi.Issue ConvertToIssue(IssueMatch match)
{
if (int.TryParse(match.Column, NumberStyles.None, CultureInfo.InvariantCulture, out var column))
{
issue.Data["column"] = column.ToString(CultureInfo.InvariantCulture);
issue.Data["col"] = column.ToString(CultureInfo.InvariantCulture);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue created via ::error:: use col, issue created via problem matcher use column...

@TingluoHuang TingluoHuang force-pushed the users/tihuang/fixissuedatamismatch branch from c0e8153 to 2a46175 Compare October 1, 2019 21:20
@TingluoHuang TingluoHuang merged commit cce1482 into master Oct 2, 2019
@TingluoHuang TingluoHuang deleted the users/tihuang/fixissuedatamismatch branch October 2, 2019 00:36
volker-raschek pushed a commit to dedalus-cis4u/github-runner-role that referenced this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants