support multi-subject attestations #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian DeHamer <[email protected]>
|
|
||
| if (opts.pushToRegistry) { | ||
| if (subjects.length === 1 && opts.pushToRegistry) { |
There was a problem hiding this comment.
This means that we don't push multi subject attestations to an OCI registry, right? If so then it should be part of the updated readme I think.
There was a problem hiding this comment.
There's really no change in behavior here. Currently, the only way to identify multiple subjects when calling the action is through a file glob. When identifying an image by name & digest you are limited to a single subject.
There have been a number of requests to support the attestation of multiple images at the same time, but we haven't yet tackled this work.
kommendorkapten
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attesting multiple subjects at the same time, a single attestation will be created with references to each of the supplied subjects. This replaces the previous behavior which resulted in a separate attestation for each subject.
Also lowers the limit on the number of subjects which can be attested at a time from 2500 to 1024. Attesting more than 1024 subjects will require additional invocations of the action.