Changing the getRedirect function to protected as I need to extend the c... #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e class at this point. Use Case: I have a guest login system which uses a separate route to login (zfcuser/guest) and the redirect plug-in is looking explicitly for zfcuser/login to do a redirect. I want to extend the RedirectCallback class with my own which does a check for the login/guest route, set the $currentRoute variable to zfcuser/login then call the parent function. No code duplication. At the moment it requires the entire class to be coppied/pasted to achieve the same functionality.
|
I am wondering if we should change the other methods/vars to protected. |
|
No disrespect to @Ocramius But, you should probably ask the reason when Marco advises you to do/change something. |
Danielss89
added a commit
that referenced
this pull request
Aug 8, 2014
Changing the getRedirect function to protected as I need to extend the c...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...lass at this point.
Use Case: I have a guest login system which uses a separate route to login (zfcuser/guest) and the redirect plug-in is looking explicitly for zfcuser/login to do a redirect. I want to extend the RedirectCallback class with my own which does a check for the login/guest route, set the $currentRoute variable to zfcuser/login then call the parent function. No code duplication. At the moment it requires the entire class to be coppied/pasted to achieve the same functionality.