Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: Change redirect strategy #487

Merged
merged 4 commits into from
Jul 3, 2014
Merged

1.x: Change redirect strategy #487

merged 4 commits into from
Jul 3, 2014

Conversation

Danielss89
Copy link
Member

I change the way the redirect strategy works.
The redirects from authenticate/logout actions are now callbacks.
This way the user can overwrite the default callback and decide exactly what to should happen.

closes #479
closes #476
closes #473
closes #469

$options = $sm->get('zfcuser_module_options');

return new RedirectCallback($application, $router, $options);
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment seems broken

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Danielss89 Danielss89 changed the title Change redirect strategy 1.x: Change redirect strategy Jul 3, 2014
@Danielss89
Copy link
Member Author

I think this is good.
@Ocramius care to press the mergebutton?

@Ocramius
Copy link
Contributor

Ocramius commented Jul 3, 2014

:shipit:

Danielss89 added a commit that referenced this pull request Jul 3, 2014
Change redirect strategy
@Danielss89 Danielss89 merged commit 4036d0c into ZF-Commons:1.x Jul 3, 2014
@Ocramius
Copy link
Contributor

Ocramius commented Jul 3, 2014

@Danielss89 issue may need labels/milestone?

@Danielss89 Danielss89 added this to the 1.2.0 milestone Jul 3, 2014
@Danielss89
Copy link
Member Author

Added

Mvh.
Daniel Strøm

On Thu, Jul 3, 2014 at 5:54 PM, Marco Pivetta [email protected]
wrote:

@Danielss89 https://github.com/Danielss89 issue may need
labels/milestone?


Reply to this email directly or view it on GitHub
#487 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants