feat: azure byoc #11
feat: azure byoc #11
Conversation
| cacheKey = await cacheHttpClient.saveCache( | ||
| 'azure_blob', | ||
| key, | ||
| cacheVersion, | ||
| archivePath, | ||
| // S3 Params are undefined for GCS | ||
| undefined, | ||
| undefined, | ||
| undefined, | ||
| undefined, | ||
| // GCS Params are undefined for Azure Blob | ||
| undefined, | ||
| undefined, | ||
| undefined, | ||
| reserveCacheResponse?.result?.azure_blob?.pre_signed_url ?? '' |
There was a problem hiding this comment.
Why is this not an object?
There was a problem hiding this comment.
Not important to change now but this looks like a low hanging fruit to improve safety.
There was a problem hiding this comment.
Yup. This needs to be fixed.
| core.debug('Uploading cache') | ||
| const blockBlobClient = new BlockBlobClient(AzureSASURL) | ||
| await blockBlobClient.uploadFile(archivePath, { | ||
| maxSingleShotSize: 10 * 1024 * 1024 // 10 MB |
There was a problem hiding this comment.
Should we increase or leave the default?
If the size of the data is less than or equal to this value, it's uploaded in a single put rather than broken up into chunks. If the data is uploaded in a single shot, the block size is ignored. Default value is 256 MiB.
From https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-upload-javascript
There was a problem hiding this comment.
Default value for parallel uploads is way higher than what we use across other providers. That's why it is overridden here.
No description provided.