-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about unsupported motions #3670
Conversation
Travis tests have failedHey @karlhorky, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
TravisBuddy Request Identifier: e35c2680-5b96-11e9-8b34-015589fd6260 |
Should we start using GH wiki's? Can I open them for editing to anybody? that might be a quicker/easier way to share information to the community. |
Created the wiki. Wanna try moving these docs there? https://github.com/VSCodeVim/Vim/wiki |
I would suggest against GitHub wikis. It moves the documentation out of code into a proprietary system (which first of all means, one more thing to maintain, one more system to have to configure). I have found that it decreases visibility of the documentation too, leading to confusing situations and splintered SEO. Having the documentation in code allows for portability and also interesting other features, such as updating the documentation for features as part of their pull requests. I don't see any positives from moving to a GitHub wiki. If the VSCodeVim team decides to nevertheless go for a GitHub wiki after consideration, I will update the wiki. |
Benefits I see of using a wiki:
My time in maintaining this project is fairly limited. I'm hoping moving to a wiki will allow the community to help maintain. It was fairly easy to configure -- ie. one is already setup.
If angular/react are able to do solve this, why can't we? https://github.com/angular/angular.js/wiki
Portability? Not sure I see your argument there. Forking the repo will also fork the wiki AFAIK. |
Okay, seems like you have some pretty strong opinions. Since you're the sole maintainer at the moment, if we don't find another way, then it seems like it's that is the way to go. Some responses (TLDR: maybe we can get more maintainers instead?):
I would propose that forking + PR + review + approval is such standard practice and no less well-known than editing the Wiki (which may or may not exist for a GitHub project - readmes are almost always present).
Totally get this. Maybe the solution is not a new tool, but another maintainer? I'm sure there are a lot of passionate people that would like to get involved here (myself included). Maybe open a call for co-maintainers?
Angular.js is the old pre-v2 Angular. The new Angular does not use GitHub wikis. And React is not using a wiki, they have their own docs site: I have not seen GitHub wikis effectively implemented in open source projects except for a few academic project exceptions. And even then, it was confusing to have them separate from the other documentation in the project (which was in code).
Portability is not just about forking. Cloning the project does not clone the wiki (you have to use a separate URL for this, which again, may or may not exist). And once forked, the wiki doesn't follow the normal PR flow.
This is the first use case that I would agree justifies a new tool. But I would suggest to do this separately and only for community discussions. And now that GitHub has acquired and integrated Spectrum, maybe that would be a better option for a community platform (see https://spectrum.chat/next-js for an example)
Interesting, I actually see this as a plus. I like going to one page and being able to use the super-fast Find in Page in my browser to find the information that I need. For example, I like the Next.js readme, the Ramda docs. |
I wonder why the following doesn't work. VS Code's keybindings.json settings file.
Then, in
|
I let k and j behave natively as they should in Vim, and configure the up and down arrows to move across wrapped lines as typically desired in prose writing: In VSCode settings.json, I added the following: In VScode keybindings.json, I added the following: |
What this PR does / why we need it:
As @alexpattison mentions in #3623 (comment), there is a caveat that causes motions involving j and k to not work with the performant line-wrapping solution.
Which issue(s) this PR fixes
This documents the issue as well as linking to a solution if this caveat is unacceptable to users.
cc @jpoon @alexpattison