fix(Dialog&Drawer): Esc key Conflict #5143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wesley-0808
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
commit: |
|
大佬，终于出手了！！ |
|
@uyarn 看下hooks里的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
🤔️ 需求背景
看到23年有个PR #3728 @sinbadmaster 做了一半，拉下来之后发现逻辑不太对，不能解决issue中提到的问题。
💡 解决方案
1. 优化弹窗管理，将
Drawer添加到弹窗管理的钩子中(#3635)2.
Drawer和Dialog中键盘监听事件中添加阻止事件传播(冒泡）。Issue中esc操作的调用顺序是：Dialog触发Event后Drawer再触发Event，阻止冒泡后Drawer就不再会触发Event了📝 更新日志
fix(Drawer): 修复配合
Dialog使用场景，esc按键关闭功能与Dialog关闭功能冲突的问题fix(Dialog): 修复配合
Drawer使用场景，esc按键关闭功能与Drawer关闭功能冲突的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单