refactor(menu): component optimization #5073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangpaopao0609
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
|
这里的错误应该是 hooks 对同名的 props 和 slot 处理的优先级问题，从目前的结果看，是 slot 优先了，这里要排查一下 
|
|
排查发现是这里写错了，这里应该返回 boolean 才对，但这里默认返回的是一个空对象，也就是 true // packages/components/utils/render-tnode.ts getSlotFirst // packages/components/hooks/tnode.ts useTNodeJSX 
|
|
是的 props优先 |
commit: |
|
又发现一个 bug 更有趣的是，这里的单测一直都是过的，当然，这是因为之前的 slotFirst bug 导致的 |
zhangpaopao0609
force-pushed
the
feature/paopao/component-optimization-menu
branch
from
d82c7d1 to
9ed3eb7
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#5047
📝 更新日志
refactor(menu): component optimization
本条 PR 不需要纳入 Changelog