Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datetimepicker): onConfirm非必填 #1061

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix(datetimepicker): onConfirm非必填 #1061

merged 1 commit into from
Aug 29, 2023

Conversation

LoopZhou
Copy link
Collaborator

@LoopZhou LoopZhou commented Aug 29, 2023 •
edited by anlyyao
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

示例
https://stackblitz.com/edit/u5mx16-hr3j5k?file=src%2Fdemo.vue

没有写onConfirm时，控制台报错

image

💡 需求背景和解决方案

onConfirm api文档是非必填。目前没有传onConfirm会报错，增加非空判断

📝 更新日志

  • fix(DateTimePicker): 修复 onConfirm 为空时，控制台报错

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

完成

@anlyyao anlyyao merged commit 6b9d9da into Tencent:develop Aug 29, 2023
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anlyyao anlyyao anlyyao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoopZhou @anlyyao