-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: align startIndex & endIndex to lanes for masonry mode #933
Conversation
Without fix
With fix
|
Easy way for reproducing bug - just set overscan 0 for MasonryVerticalVirtualizerVariable example https://tanstack.com/virtual/latest/docs/framework/react/examples/variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, let's update the condition and we can merge it.
packages/virtual-core/src/index.ts
Outdated
measurements[endIndex]!.end < scrollOffset + outerSize | ||
) { | ||
endIndex++ | ||
} | ||
|
||
if (lanes != 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (lanes != 1) { | |
if (lanes > 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, I fixed it
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
View your CI Pipeline Execution ↗ for commit a2cde5d.
☁️ Nx Cloud last updated this comment at |
@Azq2 thanks, btw did you noticed the formatting check? |
@piecyk Yes, I missed it. Now it's fixed. |
Fix for #573