-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(form-core): reduce instantiations when type checking #1262
Open
chorobin
wants to merge
31
commits into
TanStack:main
Choose a base branch
from
chorobin:perf-annotations-deep-key-values
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
perf(form-core): reduce instantiations when type checking #1262
chorobin
wants to merge
31
commits into
TanStack:main
from
chorobin:perf-annotations-deep-key-values
+1,593
−781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 22bf0d2.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
- Coverage 88.81% 88.79% -0.02%
==========================================
Files 28 28
Lines 1269 1267 -2
Branches 331 329 -2
==========================================
- Hits 1127 1125 -2
Misses 127 127
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e annotations and remove Omit
…es' into perf-annotations-deep-key-values
…es' into perf-annotations-deep-key-values
…es' into perf-annotations-deep-key-values
…es' into perf-annotations-deep-key-values
…es' into perf-annotations-deep-key-values
…es' into perf-annotations-deep-key-values
…es' into perf-annotations-deep-key-values
…es' into perf-annotations-deep-key-values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used the large example in the repo (this isn't very large so difference is not so large) to check reduction in instantiations and type checking time. I am using
extendedDiagnostics
but also traced the exampleBefore:
After
There are three main things contributing to lower instantiations:
TName
is not constrained and uses aValidateName
utility instead. I prefer not to use contraints at inference sites against complex types that could be unions. This is becauseTName
could default to the union and this can slow things down in a few situations.DeepKeys
andDeepValue
. Instead of creating a union and then parsingTName
again, a map is constructed soTValue
can be grabbed byTName
.TName
->TValue