feat(core): form listeners #1261
Open
+283
−6,268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit cd42633.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
+ Coverage 88.81% 88.89% +0.08%
==========================================
Files 28 28
Lines 1269 1279 +10
Branches 331 331
==========================================
+ Hits 1127 1137 +10
Misses 127 127
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Do not merge until 'infinite type' I've fixed 🤟 
|
harry-whorlow
commented
Mar 12, 2025
Comment on lines
+2027
to
+2039
| const form = new FormApi({ | ||
| defaultValues: { | ||
| items: ['one', 'two'], | ||
| age: 0, | ||
| }, | ||
| listeners: { | ||
| onChange: ({ formApi, fieldName }) => { | ||
| arr = formApi.state.values[fieldName] | ||
| name = fieldName | ||
| }, | ||
| }, | ||
| }) | ||
| form.mount() |
There was a problem hiding this comment.
I need a pointer as to why fieldName is "excessively deep and possibly infinite" it will only happen when there is more than one field in the formApi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds form listeners to formApi.