Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-form): fix createFormHook returning hooks and HoC with any types #1253

Merged

Conversation

pavle99
Copy link
Contributor

@pavle99 pavle99 commented Mar 8, 2025

No description provided.

Copy link

nx-cloud bot commented Mar 8, 2025

View your CI Pipeline Execution ↗ for commit 81a5b80.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 32s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-08 12:04:11 UTC

Copy link

pkg-pr-new bot commented Mar 8, 2025

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.51%. Comparing base (bd08c58) to head (81a5b80).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1253       +/-   ##
===========================================
- Coverage   88.73%   45.51%   -43.22%     
===========================================
  Files          28       13       -15     
  Lines        1260      145     -1115     
  Branches      331       25      -306     
===========================================
- Hits         1118       66     -1052     
+ Misses        127       69       -58     
+ Partials       15       10        -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping me with this!

@crutchcorn crutchcorn merged commit 02476bb into TanStack:main Mar 8, 2025
5 of 6 checks passed
@pavle99 pavle99 deleted the fix-createFormHook-returning-any-types branch March 8, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants