Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(solid-form): use { equals: false } #1246

Merged
merged 2 commits into from
Mar 8, 2025

Conversation

aadito123
Copy link
Member

it was using a weird createMemo hack. Solid has a { equals: false } now that will track regardless of any changes so we can avoid an unnecesary memo and array creation (yay)

Copy link

nx-cloud bot commented Mar 7, 2025

View your CI Pipeline Execution ↗ for commit 2cd9885.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 21s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-07 17:01:56 UTC

Copy link

pkg-pr-new bot commented Mar 7, 2025

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (062f55e) to head (2cd9885).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1246      +/-   ##
==========================================
+ Coverage   88.73%   90.69%   +1.95%     
==========================================
  Files          28        2      -26     
  Lines        1261       43    -1218     
  Branches      331        2     -329     
==========================================
- Hits         1119       39    -1080     
+ Misses        127        4     -123     
+ Partials       15        0      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crutchcorn
Copy link
Member

What minimum version of Solid.js is needed for this?

@aadito123
Copy link
Member Author

0.26.0

Had no idea this was there when I made the initial solid-form implementation.

@crutchcorn
Copy link
Member

Nice! Good work!

@crutchcorn crutchcorn merged commit bd08c58 into TanStack:main Mar 8, 2025
6 checks passed
@aadito123 aadito123 deleted the fix/solid-equal-false branch March 8, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants