-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(solid-form): use { equals: false } #1246
Conversation
View your CI Pipeline Execution ↗ for commit 2cd9885.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
+ Coverage 88.73% 90.69% +1.95%
==========================================
Files 28 2 -26
Lines 1261 43 -1218
Branches 331 2 -329
==========================================
- Hits 1119 39 -1080
+ Misses 127 4 -123
+ Partials 15 0 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What minimum version of Solid.js is needed for this? |
Had no idea this was there when I made the initial solid-form implementation. |
Nice! Good work! |
it was using a weird createMemo hack. Solid has a { equals: false } now that will track regardless of any changes so we can avoid an unnecesary memo and array creation (yay)