Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(form-core): remove unused imports #1245

Merged
merged 2 commits into from
Mar 8, 2025

Conversation

keyvhinng
Copy link
Contributor

Remove unused FormAsyncValidateOrFn and FormValidateOrFn imports from formOptions.ts. These types were not referenced in the file, and their removal improves code cleanliness without impacting functionality.

No functional changes.

Remove unused `FormAsyncValidateOrFn` and `FormValidateOrFn` imports from
`formOptions.ts`. These types were not referenced in the file, and their
removal improves code cleanliness without impacting functionality.

No functional changes.
Copy link

nx-cloud bot commented Mar 8, 2025

View your CI Pipeline Execution ↗ for commit 87801d5.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-08 00:36:09 UTC

Copy link

pkg-pr-new bot commented Mar 8, 2025

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (062f55e) to head (87801d5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1245   +/-   ##
=======================================
  Coverage   88.73%   88.73%           
=======================================
  Files          28       28           
  Lines        1261     1261           
  Branches      331      330    -1     
=======================================
  Hits         1119     1119           
  Misses        127      127           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crutchcorn crutchcorn merged commit 14d8702 into TanStack:main Mar 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants