Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-core): listen to array onChange events #1241

Merged
merged 12 commits into from
Mar 8, 2025

Conversation

pavle99
Copy link
Contributor

@pavle99 pavle99 commented Mar 7, 2025

Listen to array field events

Closes #1226

Copy link

nx-cloud bot commented Mar 7, 2025

View your CI Pipeline Execution ↗ for commit 56a0918.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 8s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-08 11:35:50 UTC

Copy link

pkg-pr-new bot commented Mar 7, 2025

@pavle99 pavle99 changed the title listen to array events fix(form-core): listen to array events Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (062f55e) to head (56a0918).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
+ Coverage   88.73%   88.81%   +0.07%     
==========================================
  Files          28       28              
  Lines        1261     1269       +8     
  Branches      331      330       -1     
==========================================
+ Hits         1119     1127       +8     
  Misses        127      127              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harry-whorlow harry-whorlow force-pushed the listen-to-array-field-changes branch from febdc46 to ab151ec Compare March 8, 2025 11:10
@harry-whorlow harry-whorlow changed the title fix(form-core): listen to array events fix(form-core): listen to array onChange events Mar 8, 2025
@harry-whorlow
Copy link
Contributor

@pavle99 looks good! Thanks for the contribution... and fixing my mistake 🙃. Just hang tight for a bit and I'll merge it once I get a chance to double check it all 🤟

@harry-whorlow harry-whorlow merged commit 4ef7fd1 into TanStack:main Mar 8, 2025
6 checks passed
@harry-whorlow
Copy link
Contributor

@pavle99 Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listener not run on array form field
2 participants