Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(form-core): Update philosophy heading tag levels h1 to h2.md #1204

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

KevinVandy
Copy link
Member

Unless there was a reason for h1s, I just converted headings to h2 to be consistent with the rest of the tanstack docs

Unless there was a reason for h1s, I just converted headings to h2 to be consistent with the rest of the tanstack docs
@KevinVandy KevinVandy changed the title Update philosophy heading tag levels h1 to h2.md docs(form-core) Update philosophy heading tag levels h1 to h2.md Mar 3, 2025
@KevinVandy KevinVandy changed the title docs(form-core) Update philosophy heading tag levels h1 to h2.md docs(form-core): Update philosophy heading tag levels h1 to h2.md Mar 3, 2025
Copy link
Member

@Balastrong Balastrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think they should be h2 as we do in the other docs pages.
It also seems h1 don't have much space on top doing a weird effect if used inside the page.

@Balastrong Balastrong merged commit d8f31f1 into main Mar 3, 2025
1 check passed
@Balastrong Balastrong deleted the KevinVandy-patch-1 branch March 3, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants