Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subfield data is removed properly when calling removeFieldValue #1197

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

crutchcorn
Copy link
Member

Fixes: #1178

Copy link

nx-cloud bot commented Mar 1, 2025

View your CI Pipeline Execution ↗ for commit e790627.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 13s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-01 11:21:06 UTC

Copy link

pkg-pr-new bot commented Mar 1, 2025

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (da5026e) to head (e790627).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
+ Coverage   88.68%   88.70%   +0.01%     
==========================================
  Files          28       28              
  Lines        1255     1257       +2     
  Branches      327      328       +1     
==========================================
+ Hits         1113     1115       +2     
  Misses        127      127              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit c8cfbe0 into main Mar 1, 2025
8 checks passed
@crutchcorn crutchcorn deleted the fix-remove-subfield-data branch March 1, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting field keeps data from subfields
1 participant