fix: [Security] Update Remix dependency and prevent prototype pollution vulnerabilities #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates @remix-run/node from ^2.15.0 to ^2.15.3 to resolve medium severity XSS vulnerability in cookie dependency (SNYK-JS-COOKIE-8163060)
BREAKING CHANGE: The mutateMergeDeep function now includes additional safety checks for dangerous properties to prevent prototype pollution vulnerability. This fixes the high severity security issue SNYK-JS-TANSTACKFORMCORE-8706814.
balint729
approved these changes
Feb 20, 2025
|
Hi @crutchcorn could you please check this? Our project also depends on this package and would really appreciate if this could be merged to mitigate the Security issue. |
|
View your CI Pipeline Execution ↗ for commit e74ef29.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
==========================================
- Coverage 87.86% 87.83% -0.03%
==========================================
Files 30 30
Lines 1318 1332 +14
Branches 354 360 +6
==========================================
+ Hits 1158 1170 +12
- Misses 144 146 +2
Partials 16 16 ☔ View full report in Codecov by Sentry. |
Balastrong
approved these changes
Feb 20, 2025
This was referenced Feb 20, 2025
Closed
harry-whorlow
pushed a commit
to harry-whorlow/form
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yoo! 👋
While working with TanStack Form, I noticed Snyk reporting two security vulnerabilities. This PR fixes both issues:
XSS vulnerability in cookie dependency:
Prototype pollution in mutateMergeDeep utility:
__proto__andconstructorThe changes are straightforward:
I've tested this locally and all tests pass. Both Snyk vulnerabilities should be resolved with these changes.
Let me know if you'd like me to explain anything or make any adjustments! :)