Skip to content
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Fix dependencies vulnerabities #424

Merged

Conversation

ilia-kebets-sonarsource
Copy link
Contributor

Fixes #423

@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title upgrade jest and ts-jest Fix dependencies vulnerabities Oct 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

1 similar comment
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's release the plugin and update its dependencies in SonarJS.

Comment on lines +87 to +92
"^.+\\.ts$": [
"ts-jest",
{
"babelConfig": false
}
]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned facing some issues when trying to update those dependencies last week. Was it related to this and Jest ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I tried to update everything, including TS. So there were many many issues. In this PR, I only targeted the required dependencies and a few others around them

@ilia-kebets-sonarsource ilia-kebets-sonarsource merged commit 7bac880 into master Oct 31, 2023
@ilia-kebets-sonarsource ilia-kebets-sonarsource deleted the issue-423-fix-dependencies-vulnerabilities branch October 31, 2023 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix vulnerabilities prior to SQ 10.3 release
3 participants