This repository was archived by the owner on Oct 3, 2024. It is now read-only.
Add suggestion for 'no-collection-size-mischeck' #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilchik-elena
suggested changes
Mar 24, 2022
| @@ -54,6 +54,16 @@ ruleTester.run('Collection sizes and array length comparisons should make sense' | |||
| endLine: 1, | |||
| column: 5, | |||
| endColumn: 24, | |||
| suggestions: [ | |||
| { | |||
| messageId: 'suggestFixedSizeCheck', | |||
There was a problem hiding this comment.
can we assert concrete message here?
There was a problem hiding this comment.
Nope, TypeScript ESLint allows only messageId.
| @@ -31,9 +31,11 @@ const rule: TSESLint.RuleModule<string, string[]> = { | |||
| messages: { | |||
| fixCollectionSizeCheck: | |||
| 'Fix this expression; {{propertyName}} of "{{objectName}}" is always greater or equal to zero.', | |||
| suggestFixedSizeCheck: 'Replace {{operation}} check with "{{operator}}"', | |||
There was a problem hiding this comment.
Use "{{operator}}" for {{operation}} check
|
Kudos, SonarCloud Quality Gate passed! |
vilchik-elena
approved these changes
Mar 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SonarSource/SonarJS#3021