Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in latest release 13.0.1 #3292

Merged
merged 21 commits into from
Feb 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
35a1f99
Fix translation path (#3198)
ludoboludo Jan 17, 2024
bd7a22d
Change product variant swatches' border color (#3204)
melissaperreault Jan 18, 2024
f6dae5f
Update swatch setting info text (#3205)
melissaperreault Jan 22, 2024
b82d852
[Quick order list] Change 'plural' string to 'singular' when removing…
eugenekasimov Jan 23, 2024
17d060a
Fix drawer stylings (#3248)
ludoboludo Feb 8, 2024
fce0b05
fix missing alt tags for collection images (#3262)
renanvsouza Feb 8, 2024
13842fe
Update titles (#3265)
ludoboludo Feb 8, 2024
722c340
Condense country selector width when there are no currencies (#3269)
hamideha Feb 9, 2024
a056c6b
Recreate existing PR based on the right branch (#3274)
ludoboludo Feb 13, 2024
3c3c270
Fix product review alignment when product doesn't have medias (#3264)
ludoboludo Feb 13, 2024
45cab49
Touch up scroll into view PDP (#3276)
ludoboludo Feb 14, 2024
3450adc
remove unused data attribute (#3277)
ludoboludo Feb 14, 2024
3bba771
Remove sticky header on cart drawer to avoid overlap of content (#3279)
ludoboludo Feb 15, 2024
a1173a3
fix scrolling scenario on mobile (#3286)
ludoboludo Feb 20, 2024
69f5677
Update 1 translation file (#3202)
translation-platform[bot] Jan 24, 2024
68659c7
Pull update from release branch and update version number and release…
ludoboludo Jan 31, 2024
dbe1b41
Update 1 translation file (#3232)
translation-platform[bot] Feb 5, 2024
4fee1da
Update README.md (#3128)
benjaminsehl Feb 7, 2024
eb4a2f7
Fix Theme Check offences (#3283)
KaichenWang Feb 16, 2024
ebe4bac
update release notes
ludoboludo Feb 22, 2024
0c72917
Merge branch 'main' into pull-in-latest-release-13.0.1
ludoboludo Feb 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions assets/component-cart-drawer.css
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ cart-drawer:not(.is-empty) .cart-drawer__collection {
}

.drawer__close svg {
height: 2.4rem;
width: 2.4rem;
height: 2rem;
width: 2rem;
}

.drawer__contents {
Expand Down Expand Up @@ -132,7 +132,7 @@ cart-drawer-items.is-empty + .drawer__footer {
display: flex;
position: relative;
line-height: 1;
padding: 1.5rem 0;
padding: 1.5rem 2.8rem 1.5rem 0;
}

.drawer__footer > details + .cart-drawer__footer {
Expand Down Expand Up @@ -182,9 +182,6 @@ cart-drawer {
.cart-drawer thead {
display: inline-table;
width: 100%;
position: sticky;
top: 0;
z-index: 2;
}

cart-drawer-items {
Expand All @@ -205,7 +202,7 @@ cart-drawer-items {
.cart-drawer .cart-item {
display: grid;
grid-template: repeat(2, auto) / repeat(4, 1fr);
gap: 1.5rem;
gap: 1rem;
margin-bottom: 0;
}

Expand Down Expand Up @@ -255,7 +252,7 @@ cart-drawer-items {
}

.cart-drawer .cart-items td {
padding-top: 2rem;
padding-top: 1.7rem;
}

.cart-drawer .cart-item > td + td {
Expand Down Expand Up @@ -312,7 +309,7 @@ cart-drawer-items {
}

.cart-drawer .tax-note {
margin: 1.2rem 0 1rem auto;
margin: 1.2rem 0 2rem auto;
text-align: left;
}

Expand Down
5 changes: 4 additions & 1 deletion assets/component-localization-form.css
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,14 @@ noscript .localization-selector.link {
}

.country-selector__list {
width: 25.5rem;
padding-bottom: 0.95rem;
padding-top: 0;
}

.country-selector__list--with-multiple-currencies {
width: 25.5rem;
}

.country-selector__close-button {
display: none;
}
Expand Down
4 changes: 4 additions & 0 deletions assets/component-rating.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
.product--no-media .rating-wrapper {
text-align: center;
}

.rating {
display: inline-block;
margin: 0;
Expand Down
10 changes: 6 additions & 4 deletions assets/media-gallery.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,14 @@ if (!customElements.get('media-gallery')) {

this.preventStickyHeader();
window.setTimeout(() => {
if (this.elements.thumbnails) {
if (!this.mql.matches || this.elements.thumbnails) {
activeMedia.parentElement.scrollTo({ left: activeMedia.offsetLeft });
}
if (!this.elements.thumbnails || this.dataset.desktopLayout === 'stacked') {
activeMedia.scrollIntoView({ behavior: 'smooth' });
}
const activeMediaRect = activeMedia.getBoundingClientRect();
// Don't scroll if the image is already in view
if (activeMediaRect.top > -0.5) return;
const top = activeMediaRect.top + window.scrollY;
window.scrollTo({ top: top, behavior: 'smooth' });
});
this.playActiveMedia(activeMedia);

Expand Down
21 changes: 8 additions & 13 deletions release-notes.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
Dawn 13.0.0 adds support for color swatches, improvements to the country selector, and tweaks and fixes to other sections. It also includes a breaking change to Color Schemes; see the Changed notes below for details.
### Added
- The Variant Picker now supports color swatches! This depends on the [Product Taxonomy](help.shopify.com/manual/products/details/product-category) feature, which is rolling out gradually over the coming weeks.
- We reworked the country selector, which now includes search, a new “popular countries” section, and a generally improved look and feel especially on smaller screens.
Dawn 13.0.1 introduces a few fixes.
### Changed
- **Important**: If you use Color Schemes, they will reset to their default values due to an internal change to the feature.
- If you are using the Search & Discovery app, you can now change how dynamic facet lists treat filters with no product matches.
- The cart drawer header (Product, Total) is not sticky anymore when the content is scrollable
### Fixes and improvements
- We added a default font for input fields, they now inherit the body font instead of falling back to a system default font.
- We fixed an issue when adding cart notes that would prevent them from showing during checkout.
- We fixed an accessibility bug where filter colors were displaying incorrectly in high contrast mode.
- We updated the Multicolumn Section to provide a slider on tablet-sized screens, like it does on phone-sized screens.
- We fixed a bug where the Localization Selector was slightly obscured when using Sticky Header and scrolling while the selector was open.
- We fixed a bug that prevented the Product Grid Section from using the correct Image Shape in its Product Cards.
- We subtly increased the font size for inline quantity errors on product pages to make them more readable.
- Fix product rating alignment when the product doesn't have a media
- Fix scroll issue on variant change
- Limit width of country selector when the currency is the same for all the countries
- Fix missing alt tags for the collection image on the collection page as well as for collection cards
- Fix cart drawer's cart note to prevent overlapping of the text and caret icon
- Fix cart drawer's header to prevent an overlap with the items in the cart
2 changes: 1 addition & 1 deletion sections/collapsible-content.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
<summary id="Summary-{{ block.id }}-{{ section.id }}">
{% render 'icon-accordion', icon: block.settings.icon %}
<h3 class="accordion__title inline-richtext h4">
{{ block.settings.heading | default: block.settings.page.title }}
{{ block.settings.heading | default: block.settings.page.title | escape }}
</h3>
{% render 'icon-caret' %}
</summary>
Expand Down
2 changes: 1 addition & 1 deletion sections/featured-collection.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
<a
href="{{ section.settings.collection.url }}"
class="{% if section.settings.view_all_style == 'link' %}link underlined-link{% elsif section.settings.view_all_style == 'solid' %}button{% else %}button button--secondary{% endif %}"
aria-label="{{ 'sections.featured_collection.view_all_label' | t: collection_name: section.settings.collection.title }}"
aria-label="{{ 'sections.featured_collection.view_all_label' | t: collection_name: section.settings.collection.title | escape }}"
>
{{ 'sections.featured_collection.view_all' | t }}
</a>
Expand Down
66 changes: 34 additions & 32 deletions sections/featured-product.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -468,39 +468,41 @@
{{ block.settings.custom_liquid }}
{%- when 'rating' -%}
{%- if product.metafields.reviews.rating.value != blank -%}
{% liquid
assign rating_decimal = 0
assign decimal = product.metafields.reviews.rating.value.rating | modulo: 1
if decimal >= 0.3 and decimal <= 0.7
assign rating_decimal = 0.5
elsif decimal > 0.7
assign rating_decimal = 1
endif
%}
<div
class="rating"
role="img"
aria-label="{{ 'accessibility.star_reviews_info' | t: rating_value: product.metafields.reviews.rating.value, rating_max: product.metafields.reviews.rating.value.scale_max }}"
>
<span
aria-hidden="true"
class="rating-star"
style="--rating: {{ product.metafields.reviews.rating.value.rating | floor }}; --rating-max: {{ product.metafields.reviews.rating.value.scale_max }}; --rating-decimal: {{ rating_decimal }};"
></span>
<div class="rating-wrapper">
{% liquid
assign rating_decimal = 0
assign decimal = product.metafields.reviews.rating.value.rating | modulo: 1
if decimal >= 0.3 and decimal <= 0.7
assign rating_decimal = 0.5
elsif decimal > 0.7
assign rating_decimal = 1
endif
%}
<div
class="rating"
role="img"
aria-label="{{ 'accessibility.star_reviews_info' | t: rating_value: product.metafields.reviews.rating.value, rating_max: product.metafields.reviews.rating.value.scale_max }}"
>
<span
aria-hidden="true"
class="rating-star"
style="--rating: {{ product.metafields.reviews.rating.value.rating | floor }}; --rating-max: {{ product.metafields.reviews.rating.value.scale_max }}; --rating-decimal: {{ rating_decimal }};"
></span>
</div>
<p class="rating-text caption">
<span aria-hidden="true">
{{- product.metafields.reviews.rating.value }} /
{{ product.metafields.reviews.rating.value.scale_max -}}
</span>
</p>
<p class="rating-count caption">
<span aria-hidden="true">({{ product.metafields.reviews.rating_count }})</span>
<span class="visually-hidden">
{{- product.metafields.reviews.rating_count }}
{{ 'accessibility.total_reviews' | t -}}
</span>
</p>
</div>
<p class="rating-text caption">
<span aria-hidden="true">
{{- product.metafields.reviews.rating.value }} /
{{ product.metafields.reviews.rating.value.scale_max -}}
</span>
</p>
<p class="rating-count caption">
<span aria-hidden="true">({{ product.metafields.reviews.rating_count }})</span>
<span class="visually-hidden">
{{- product.metafields.reviews.rating_count }}
{{ 'accessibility.total_reviews' | t -}}
</span>
</p>
{%- endif -%}
{%- when 'icon-with-text' -%}
{% render 'icon-with-text', block: block %}
Expand Down
2 changes: 1 addition & 1 deletion sections/main-collection-banner.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"
src="{{ collection.image | image_url: width: 750 }}"
sizes="(min-width: {{ settings.page_width }}px) {{ settings.page_width | minus: 100 | divided_by: 2 }}px, (min-width: 750px) calc(50vw - 130px), calc(50vw - 55px)"
alt=""
alt="{{ collection.image.alt | escape }}"
width="{{ collection.image.width }}"
height="{{ collection.image.height }}"
>
Expand Down
Loading
Loading