Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim down the height of the announcement bar on desktop #2807

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Slim down the height of the announcement bar on desktop #2807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c40968
Adjust height of announcement bar and sub-items.
kjellr Jul 10, 2023
349169d
Adjust announcement bar button height on desktop only.
kjellr Jul 10, 2023
310b916
Fix width of the utility bar on mobile.
kjellr Jul 10, 2023
dff48f2
Remove bizarre rem-based values.
kjellr Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion assets/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,18 @@ body:has(.section-header .drawer-menu) .announcement-bar-section .page-width {
margin: 0 auto;
}

.utility-bar__grid.page-width {
padding-left: 3rem;
padding-right: 3rem;
}

@media screen and (min-width: 750px) {
.page-width {
padding: 0 5rem;
}

.header.page-width {
.header.page-width,
.utility-bar__grid.page-width {
padding-left: 3.2rem;
padding-right: 3.2rem;
}
Expand Down Expand Up @@ -2233,6 +2239,10 @@ product-info .loading-overlay:not(.hidden) ~ *,
.announcement-bar-slider {
width: 60%;
}

.announcement-bar .slider-button {
height: 3.8rem;
}
}

.announcement-bar__link {
Expand Down Expand Up @@ -2266,6 +2276,7 @@ product-info .loading-overlay:not(.hidden) ~ *,
padding: 1rem 0;
margin: 0;
letter-spacing: 0.1rem;
min-height: 3.8rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're ok with this, I probably am, but historically we do make a best effort to keep things 44px. Just want to double check we don't want to add in the additional 6px. In theory a tablet touch device could display at the desktop breakpoint and still benefit from the 44px min.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm ok with 38px for desktop. 👍

}

.announcement-bar-slider--fade-in-next .announcement-bar__message,
Expand Down
5 changes: 5 additions & 0 deletions assets/component-list-social.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@
color: rgb(var(--color-foreground));
}

.utility-bar .list-social__link {
padding: 0 1.1rem;
height: 3.8rem;
}

.list-social__link:hover .icon {
transform: scale(1.07);
}
4 changes: 3 additions & 1 deletion assets/component-localization-form.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,14 @@ noscript .localization-selector.link {
/* Header localization */
.header-localization .localization-form:only-child {
margin: 0;
padding: 0;
}

.header-localization .disclosure .localization-form__select {
font-size: 1.4rem;
letter-spacing: 0.06rem;
height: auto;
min-height: initial;
background: transparent;
}

Expand Down Expand Up @@ -234,12 +236,12 @@ noscript .localization-selector.link {

.header-localization:not(.menu-drawer__localization) {
align-items: center;
min-height: 4.4rem;
}

.js .header-localization:not(.menu-drawer__localization) .localization-form__select {
padding: 0 2.7rem 0 1.2rem;
width: max-content;
height: 3.8rem;
}

.header-localization:not(.menu-drawer__localization) .localization-form:only-child .localization-form__select {
Expand Down