[Discounts] fix: show accurate subtotal price for cart #2775

mathiusj · 2023-07-05T21:01:21Z

PR Summary:

Updates total price to be items_subtotal_price to more accurately represent the value after line item discounts only.

Before:

After:

Why are these changes introduced?

fixes: https://github.com/Shopify/core-issues/issues/57440
fixes: #2781

What approach did you take?

Other considerations

Decision log

#	Decision	Alternatives	Rationale	Downsides
1

Visual impact on existing themes

Testing steps/scenarios

manually edited in store editor: https://admin.web.fix-inaccurate-total.mathius-johnson.us.spin.dev/store/shop1/themes/1?key=sections%2Fmain-cart-footer.liquid

cart: https://shop1.shopify.fix-inaccurate-total.mathius-johnson.us.spin.dev/cart

add products to cart
go to checkout and add product + order discounts (take note of total price after order discount)
go back to cart and confirm subtotal accurately reflects amount of line items - line item discounts, order discount not included (should be a higher amount than total price with order discount applied)

Demo links

Store
Editor

Checklist

Added PR summary for release notes
Requested review from UX (Only for changes that are affecting the experience or perceivable visual details)
Created a ticket for the help.shopify.com documentation team about updates to theme settings. (Internal-only task)
Followed theme code principles
Linted with Theme Check
Tested on mobile
Tested on multiple browsers
Tested for accessibility

devisscher · 2023-07-06T13:40:30Z

This looks clearer for the merchant, but as you mentioned @mathiusj, an additional total line after the order discounts are applied could make it even clearer. Another thing to account for is the cart drawer, which should be found here, see screenshot below.:

ludoboludo · 2023-07-06T19:06:21Z

Hey folks, not a review but just some context around some other things we were looking into for the customer account page. We wanted to make the hierarchy of the information similar to what you (customer) also receive as an email notification. So we have some consistency.

Here is a PR about it. It's not directly related but maybe good to know/be aware of for consistency across the board 👍

translation-platform · 2023-07-07T15:01:45Z

locales/en.default.json

@@ -272,8 +272,8 @@
      "title": "Your cart",
      "caption": "Cart items",
      "remove_title": "Remove {{ title }}",
-      "subtotal": "Subtotal",
-      "new_subtotal": "New subtotal",
+      "estimated_total": "Estimated Total",


Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

The value Estimated Total for key sections.cart.estimated_total is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

ludoboludo · 2023-07-07T17:35:14Z

assets/component-totals.css

+.totals__total {
+  margin-top: .5rem;
+}


I don't think we need this. It applies that margin top even when there are no discounts above it.

We do have this existing declaration:

.cart__footer .discounts { margin-top: 1rem; }

Which could be changed to margin-bottom 👍

Then I'd like to see what a designer will think as the spacing between the total and the taxes and shipping... is bigger than between the discount and the total 🤔

Spacing looks good on my end. We can revise further if we decide to bring the subtotal in here too. 👍

translation-platform · 2023-07-07T18:23:24Z

locales/en.default.json

@@ -272,8 +272,8 @@
      "title": "Your cart",
      "caption": "Cart items",
      "remove_title": "Remove {{ title }}",
-      "subtotal": "Subtotal",
-      "new_subtotal": "New subtotal",
+      "estimated_total": "Estimated total",


Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

The value Estimated total for key sections.cart.estimated_total is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

I added a new screenshot with more details for the translation platform 👍

Thank you!!! 🙏

ludoboludo

Looking good to me 👍

One note, some stores could be using free shipping methods only and include taxes in their product prices. So the total amount on the cart page could be exactly the same as the one during checkout.
Though since you can always add a discount during checkout, I think it's ok to keep it as is 👍

⚠️ And we will need to wait for the translations to be back before merging.

kjellr

Looks good from the UX side. Thank you! 🙌

mathiusj · 2023-07-11T15:44:25Z

/shipit

* fix: show accurate subtotal price for cart * chore: update subtotal in cart drawer * chore: update copy for estimated total, adjust spacing and placement * fix: use cart__footer selector for margin instead * fix: make copy sentence case * Update 20 translation files * Update 3 translation files * Update 7 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

mathiusj changed the title ~~fix: show accurate subtotal price for cart~~ [Discounts] fix: show accurate subtotal price for cart Jul 5, 2023

mathiusj requested review from aeperea and devisscher July 5, 2023 22:01

mathiusj marked this pull request as ready for review July 6, 2023 16:00

mathiusj mentioned this pull request Jul 6, 2023

Investigate if content in cart needs to be updated to show Total as well as Subtotal #2781

Closed

mathiusj requested a review from ludoboludo July 6, 2023 16:15

kimberlyoleiro assigned mathiusj Jul 7, 2023

translation-platform bot reviewed Jul 7, 2023

View reviewed changes

mathiusj force-pushed the mathiusj/gh-57440-fix-inaccurate-subtotal-price branch 3 times, most recently from 6ae58e0 to f35050a Compare July 7, 2023 15:07

mathiusj requested a review from kjellr July 7, 2023 15:08

mathiusj force-pushed the mathiusj/gh-57440-fix-inaccurate-subtotal-price branch from f35050a to 8e796cc Compare July 7, 2023 15:09

ludoboludo reviewed Jul 7, 2023

View reviewed changes

translation-platform bot reviewed Jul 7, 2023

View reviewed changes

ludoboludo approved these changes Jul 7, 2023

View reviewed changes

stephanie-shopify approved these changes Jul 7, 2023

View reviewed changes

devisscher approved these changes Jul 8, 2023

View reviewed changes

kjellr approved these changes Jul 10, 2023

View reviewed changes

mathiusj and others added 8 commits July 11, 2023 08:39

fix: show accurate subtotal price for cart

83b61c9

chore: update subtotal in cart drawer

ff18d9a

chore: update copy for estimated total, adjust spacing and placement

b21b096

fix: use cart__footer selector for margin instead

1d24472

fix: make copy sentence case

4395a5f

Update 20 translation files

0688878

Update 3 translation files

34df7bb

Update 7 translation files

7b4e630

mathiusj force-pushed the mathiusj/gh-57440-fix-inaccurate-subtotal-price branch from 3b876ec to 7b4e630 Compare July 11, 2023 15:40

mathiusj merged commit 45bced2 into main Jul 11, 2023

mathiusj deleted the mathiusj/gh-57440-fix-inaccurate-subtotal-price branch July 11, 2023 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discounts] fix: show accurate subtotal price for cart #2775

[Discounts] fix: show accurate subtotal price for cart #2775

mathiusj commented Jul 5, 2023 •

edited

Loading

devisscher commented Jul 6, 2023

ludoboludo commented Jul 6, 2023

translation-platform bot Jul 7, 2023

ludoboludo Jul 7, 2023

ludoboludo Jul 7, 2023

kjellr Jul 10, 2023

translation-platform bot Jul 7, 2023

ludoboludo Jul 7, 2023

mathiusj Jul 7, 2023

ludoboludo left a comment •

edited

Loading

kjellr left a comment

mathiusj commented Jul 11, 2023

[Discounts] fix: show accurate subtotal price for cart #2775

[Discounts] fix: show accurate subtotal price for cart #2775

Conversation

mathiusj commented Jul 5, 2023 • edited Loading

PR Summary:

Why are these changes introduced?

What approach did you take?

Other considerations

Decision log

Visual impact on existing themes

Testing steps/scenarios

Demo links

Checklist

devisscher commented Jul 6, 2023

ludoboludo commented Jul 6, 2023

translation-platform bot Jul 7, 2023

Choose a reason for hiding this comment

ludoboludo Jul 7, 2023

Choose a reason for hiding this comment

ludoboludo Jul 7, 2023

Choose a reason for hiding this comment

kjellr Jul 10, 2023

Choose a reason for hiding this comment

translation-platform bot Jul 7, 2023

Choose a reason for hiding this comment

ludoboludo Jul 7, 2023

Choose a reason for hiding this comment

mathiusj Jul 7, 2023

Choose a reason for hiding this comment

ludoboludo left a comment • edited Loading

Choose a reason for hiding this comment

kjellr left a comment

Choose a reason for hiding this comment

mathiusj commented Jul 11, 2023

mathiusj commented Jul 5, 2023 •

edited

Loading

ludoboludo left a comment •

edited

Loading