-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apps): enable configuring which hidden settings are available for the apps #35199
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: a7272fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35199 +/- ##
========================================
Coverage 59.45% 59.45%
========================================
Files 2828 2828
Lines 68159 68159
Branches 15124 15124
========================================
Hits 40521 40521
Misses 24982 24982
Partials 2656 2656
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Enhances the server-setting.read permission, allowing it to take an array of hiddenPermissions, that are the permissions that can be searched despite being hidden (or secret). This enables us to have a Omnigateway_Url setting.
This setting is going to be responsible to have the omnigateway of the current env. By having this setting, we can easily stage our omni-apps, because, instead of having the value of the omnigateway url hardcoded, it will be just a matter of fetching the value of the setting through the apps-engine. Thus, centralizing the information
Issue(s)
Steps to test or reproduce
Further comments
CONN-525