fix: Omnichannel transcript filename breaking links on some storages (#…

…35354) Co-authored-by: Jean Brito <[email protected]>
RocketChat · Feb 28, 2025 · 4ad5aef · 4ad5aef
1 parent b19ed0f
commit 4ad5aef
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/.changeset/popular-boats-poke.md b/.changeset/popular-boats-poke.md
@@ -0,0 +1,7 @@
+---
+"@rocket.chat/omnichannel-services": patch
+"@rocket.chat/pdf-worker": patch
+"@rocket.chat/meteor": patch
+---
+
+Fixes omnichannel transcript filename breaking download links
diff --git a/ee/packages/omnichannel-services/src/OmnichannelTranscript.ts b/ee/packages/omnichannel-services/src/OmnichannelTranscript.ts
@@ -519,7 +519,7 @@ export class OmnichannelTranscript extends ServiceClass implements IOmnichannelT
 					buffer,
 					details: {
 						// transcript_{company-name}_{date}_{hour}.pdf
-						name: `${transcriptText}_${data.siteName}_${new Intl.DateTimeFormat('en-US').format(new Date())}_${
+						name: `${transcriptText}_${data.siteName}_${new Intl.DateTimeFormat('en-US').format(new Date()).replace(/\//g, '-')}_${
 							data.visitor?.name || data.visitor?.username || 'Visitor'
 						}.pdf`,
 						type: 'application/pdf',

diff --git a/ee/packages/pdf-worker/src/worker.fixtures.ts b/ee/packages/pdf-worker/src/worker.fixtures.ts
@@ -424,7 +424,7 @@ export const bigConversationData = {
 			},
 			files: [
 				{
-					name: 'Transcript_Another test_4/24/2024_Alayna.pdf',
+					name: 'Transcript_Another test_4-24-2024_Alayna.pdf',
 					buffer: null,
 				},
 			],
@@ -454,7 +454,7 @@ export const bigConversationData = {
 			},
 			files: [
 				{
-					name: 'Transcript_Another test_4/24/2024_Alayna.pdf',
+					name: 'Transcript_Another test_4-24-2024_Alayna.pdf',
 					buffer: null,
 				},
 			],