Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main selector improvements #2972

Merged
merged 4 commits into from
Dec 3, 2022
Merged

Main selector improvements #2972

merged 4 commits into from
Dec 3, 2022

Conversation

tritonas00
Copy link
Collaborator

@tritonas00 tritonas00 commented Nov 23, 2022 •
edited
Loading

  • Slash (/) now focus the search bar in main selector.
  • Right/Left arrows now switch categories if search input is empty, no need to unfocus search bar to use them.
  • Properly search all categories.

Requested from discord.

@tritonas00 tritonas00 changed the title Added ImGuiKey_Slash Main selector improvements Nov 23, 2022
paroj
paroj reviewed Nov 25, 2022
View reviewed changes
source/main/gui/imgui/imgui.h
@@ -960,6 +960,7 @@ enum ImGuiKey_
ImGuiKey_KeyPad7,
ImGuiKey_KeyPad8,
ImGuiKey_KeyPad9,
ImGuiKey_Slash,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will prevent you from upgrading imgui ever again

Copy link
Collaborator Author

@tritonas00 tritonas00 Nov 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not the first time though, the ImGuiKey_KeyPad* keys above are also added by us back then

ohlidalp
ohlidalp approved these changes Dec 3, 2022
View reviewed changes
Copy link
Member

@ohlidalp ohlidalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The '/' hotkey is fantastic.
The arrow left/right keys with empty searchbox are a clever touch.
The auto-reset to "category:all" on searching makes sense, I suspect the original behavior was intentional but this is more convenient.

@tritonas00 tritonas00 merged commit f1a0704 into RigsOfRods:master Dec 3, 2022
@tritonas00 tritonas00 deleted the slash branch December 3, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paroj paroj paroj left review comments

@ohlidalp ohlidalp ohlidalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tritonas00 @ohlidalp @paroj