Fix allocate panic #123
Merged
Fix allocate panic #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
evilnoxx
commented
Oct 31, 2022
evilnoxx
commented
- Allow allocating zero amount with zero ratios
- Allow allocating an amount with zero ratios (gives zero amount to all parties)
- Added some extra test cases
added 5 commits
October 31, 2022 16:08
Rhymond
reviewed
Oct 31, 2022
| @@ -282,6 +282,12 @@ func (m *Money) Allocate(rs ...int) ([]*Money, error) { | |||
| total += party.amount | |||
| } | |||
|
|
|||
| // if the sum of all ratios is zero, then we just returns zeros and don't do anything | |||
| // with the leftover | |||
| if sum == 0 { | |||
There was a problem hiding this comment.
would it work with the case when ratios are equal to {-50, 50}? The sum is 0, how this works? To be honest with you, I'm not really sure what negative ratio means and I expect to always get unsigned integer, is there a use case I'm missing?
There was a problem hiding this comment.
I couldn't come up with a use case for negative ratios. I've added a check, that returns a new error if any of the ratios are negative.
Rhymond
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.