Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change logo to X #19

Merged
merged 4 commits into from
Sep 25, 2023
Merged

docs: change logo to X #19

merged 4 commits into from
Sep 25, 2023

Conversation

validcube
Copy link
Member

@validcube validcube commented Sep 17, 2023 •
edited
Loading

Goodbye Twitter Bird...

Not sure why the url is difference from others

@validcube
docs: change logo to X
b9b27db 
Goodbye Twitter Blue
@validcube validcube marked this pull request as draft September 17, 2023 07:15
@oSumAtrIX
Copy link
Member

Is this meant to be a draft?

@validcube
Copy link
Member Author

validcube commented Sep 21, 2023 •
edited
Loading

Looks like I can't change the url of Twitter (see cmark-gfm#342)

My workaround would be to host the asset in the repository.

My workaround would be to paste the image using github.com/org/repo/assets, when you hover on the icon, it will show URL from user-images.githubusercontent.com/image.png

@validcube validcube marked this pull request as ready for review September 23, 2023 12:39
@validcube
Copy link
Member Author

done:tm:! @oSumAtrIX

@oSumAtrIX
Copy link
Member

This has to be changed in the branding repo too

@validcube
Copy link
Member Author

This has to be changed in the branding repo too

Done:tm:

oSumAtrIX
oSumAtrIX reviewed Sep 23, 2023
View reviewed changes
@oSumAtrIX oSumAtrIX mentioned this pull request Sep 23, 2023
Merged
@validcube validcube requested a review from oSumAtrIX September 24, 2023 17:20
@oSumAtrIX oSumAtrIX merged commit addba13 into ReVanced:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oSumAtrIX oSumAtrIX Awaiting requested review from oSumAtrIX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@validcube @oSumAtrIX