Upgrade to .NET 8.0 and eradicate ☠ Mono ☠ #21577
Conversation
michaeldgg2
force-pushed
the
net80
branch
2 times, most recently
from
1852e97 to
35b23bc
Compare
|
The current dev appetite is for the next release to still use net6+mono, so this will need to wait until after that has occured at a minimum. I would recommend grepping the repo for |
michaeldgg2
changed the title
michaeldgg2
changed the title
michaeldgg2
changed the title
There was a problem hiding this comment.
It saves into ~/Documents/.config/openra/ instead of ~/.config/openra/ on Linux. https://learn.microsoft.com/dotnet/core/compatibility/core-libraries/8.0/getfolderpath-unix
There was a problem hiding this comment.
Still a few hits for net 6 in these files:
- .github\workflows\documentation.yml
- .github\workflows\packaging.yml
- packaging\functions.sh
- packaging\macos\apphost.c
- packaging\windows\buildpackage.sh
And mono in these files:
- OpenRA.Game\Exts.cs
- packaging\freebsd\openra
Extra System or Microsoft nuget packages that align with the runtime version should be bumped from 6 to 8.
.editorconfig
Outdated
| @@ -820,7 +820,7 @@ dotnet_diagnostic.CA1843.severity = warning | |||
| # Provide memory-based overrides of async methods when subclassing 'Stream'. | |||
| dotnet_diagnostic.CA1844.severity = warning | |||
|
|
|||
| # Use span-based 'string.Concat'. (Not available on mono) | |||
| # Use span-based 'string.Concat'. | |||
| dotnet_diagnostic.CA1845.severity = none | |||
There was a problem hiding this comment.
Let's set this to a warning.
| if [ -L "bin/${REPLACE}" ]; then | ||
| return 0 | ||
| fi | ||
| # .NET 6 does not support .config files, so we must use symlinks instead |
There was a problem hiding this comment.
.NET 8 - assuming the comment still holds in 8.
There was a problem hiding this comment.
With mono gone we don't have .config files at all, so this whole file needs to be updated (comments at top, function names, etc) to reflect .NET.
|
needs a rebase for support folder to be correct on Mac and Linux |
|
This would also be a good time to get rid of |
packaging/macos/launcher.m
Outdated
| dllPath = [exePath stringByAppendingPathComponent: @"x86_64/OpenRA.dll"]; | ||
| } | ||
| } | ||
| cpu_type_t type; |
There was a problem hiding this comment.
Spaces -> Tabs in this file please.
|
umm, is Mono dead or something bad happened? |
Something like that. https://www.mono-project.com/ |
|
thanks! @JovialFeline |
This reverts commit 7011b2f.
|
Somebody should take a look at FreeBSD start script too. |
|
.NET 6 is out of support since yesterday https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core |
| @@ -212,7 +208,7 @@ for MOD in "Red Alert" "Tiberian Dawn"; do | |||
| done | |||
|
|
|||
| for MOD in "Red Alert" "Tiberian Dawn" "Dune 2000"; do | |||
| for p in "arm64" "mono"; do | |||
| for p in "arm64"; do | |||
Changes
Apart from targeting .NET 8.0 this PR does other things too:
.editorconfigafter migrating to .NET 8.0 and removing MonoTODO
.editorconfig.NET 8.0 on older Windows versions
Surprisingly, not only .NET 8.0 runtime works on Windows 8.1, but also the SDK. More importantly OpenRA compiled targeting .NET 8.0 works on Windows 8.1 as well (this runs in a VM so ignore the FPS):