Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc improvements/v2 #12748

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

victorjulien
Copy link
Member

#11420 rebased and with policy renamed to match_policy.

Misc cleanups.

@victorjulien victorjulien requested a review from a team as a code owner March 10, 2025 08:33
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 83.63636% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.86%. Comparing base (5718d5c) to head (dafab4e).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12748      +/-   ##
==========================================
+ Coverage   80.85%   80.86%   +0.01%     
==========================================
  Files         936      936              
  Lines      259730   259766      +36     
==========================================
+ Hits       210000   210064      +64     
+ Misses      49730    49702      -28     
Flag Coverage Δ
fuzzcorpus 57.24% <38.18%> (-0.01%) ⬇️
livemode 19.41% <23.63%> (-0.01%) ⬇️
pcap 44.15% <23.63%> (+<0.01%) ⬆️
suricata-verify 63.66% <80.00%> (+<0.01%) ⬆️
unittests 58.14% <29.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 25041

@victorjulien victorjulien added this to the 8.0 milestone Mar 10, 2025
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 25044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants