-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] l10n_es_partner: Inject _rec_names_search properly #4057
[16.0][FIX] l10n_es_partner: Inject _rec_names_search properly #4057
Conversation
Previous patch was overriding _auto_init method for injecting the comercial field in the list of fields to search for (_rec_names_search), but this method is only called on module installation/update, so if you restart the Odoo server after that, you lose the injection. Thus, let's inject it if not present when calling name_search, and this way we always have it available. TT55241
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-4057-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-4057-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
@HaraldPanten your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-4057-by-HaraldPanten-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-4057-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Vaya, y ahora se estropea el endpoint del SII de Bizkaia... https://www.bizkaia.eus/ogasuna/sii/documentos/SuministroFactEmitidas.wsdl |
Cuestión de ir probando. Entiendo que ya está. /ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 79c814e. Thanks a lot for contributing to OCA. ❤️ |
Previous patch was overriding
_auto_init
method for injecting thecomercial
field in the list of fields to search for (_rec_names_search
), but this method is only called on module installation/update, so if you restart the Odoo server after that, you lose the injection.Thus, let's inject it if not present when calling name_search, and this way we always have it available.
@Tecnativa TT55241