Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] l10n_es_partner: Inject _rec_names_search properly #4057

Merged

Conversation

pedrobaeza
Copy link
Member

Previous patch was overriding _auto_init method for injecting the comercial field in the list of fields to search for (_rec_names_search), but this method is only called on module installation/update, so if you restart the Odoo server after that, you lose the injection.

Thus, let's inject it if not present when calling name_search, and this way we always have it available.

@Tecnativa TT55241

Previous patch was overriding _auto_init method for injecting the
comercial field in the list of fields to search for (_rec_names_search),
but this method is only called on module installation/update, so if
you restart the Odoo server after that, you lose the injection.

Thus, let's inject it if not present when calling name_search, and
this way we always have it available.

TT55241
@pedrobaeza pedrobaeza added this to the 16.0 milestone Mar 3, 2025
@pedrobaeza
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-4057-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 3, 2025
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-4057-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-4057-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 3, 2025
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-4057-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@HaraldPanten
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-4057-by-HaraldPanten-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 3, 2025
Signed-off-by HaraldPanten
@OCA-git-bot
Copy link
Contributor

@HaraldPanten your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-4057-by-HaraldPanten-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-4057-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 4, 2025
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-4057-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member Author

Vaya, y ahora se estropea el endpoint del SII de Bizkaia...

https://www.bizkaia.eus/ogasuna/sii/documentos/SuministroFactEmitidas.wsdl

@HaraldPanten
Copy link
Contributor

Cuestión de ir probando. Entiendo que ya está.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-4057-by-HaraldPanten-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0c549ed into OCA:16.0 Mar 4, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 79c814e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-fix-l10n_es_partner-name_search branch March 4, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants